Skip to content

Support multiple nanoAOD versions in one branch #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nshadskiy merged 10 commits into from
May 5, 2025
Merged

Support multiple nanoAOD versions in one branch #30

nshadskiy merged 10 commits into from
May 5, 2025

Conversation

@SimonSPD
Copy link

@SimonSPD SimonSPD commented Apr 10, 2025 •
edited
Loading

Here is a suggestion on how the sample_database could support multiple nanoAOD versions.

This is now an approach with minimal changes.

Expansion options:

  • use a getter method for providing the information in KingMaker (instead of reading the json files)
  • this getter method could use a faster database e.g. sqlite

Known issues:

  • updated xsec and gen_weights are saved automatically. So the option "exit without save" won't work.

Fixed issues:

Adapted KingMaker to use the right path: KIT-CMS/KingMaker#64

@SimonSPD SimonSPD self-assigned this Apr 10, 2025
@SimonSPD SimonSPD mentioned this pull request Apr 16, 2025
Closed
@nshadskiy
Copy link
Collaborator

nshadskiy commented Apr 30, 2025

KingMaker is now adapted with KIT-CMS/KingMaker#64, right?

@nshadskiy
Copy link
Collaborator

nshadskiy commented Apr 30, 2025 •
edited
Loading

Known issues: updated xsec and gen_weights are saved automatically. So the option "exit without save" won't work.

If this is an issue that is not solved in this PR, I suggest to make a real issue in the repository.

@SimonSPD
Copy link
Author

SimonSPD commented Apr 30, 2025

KingMaker is now adapted with KIT-CMS/KingMaker#64, right?

Yes

@SimonSPD
Copy link
Author

SimonSPD commented Apr 30, 2025 •
edited
Loading

Known issues: updated xsec and gen_weights are saved automatically. So the option "exit without save" won't work.

If this is an issue that is not solved in this PR, I suggest to make a real issue in the repository.

Created issue: #31

@nshadskiy nshadskiy mentioned this pull request May 5, 2025
Closed
@nshadskiy nshadskiy merged commit 0be5e61 into main May 5, 2025
@nshadskiy nshadskiy deleted the sdaigler/feature/support_multiple_nanoAOD_versions branch May 5, 2025 13:18
@nshadskiy nshadskiy mentioned this pull request May 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nshadskiy nshadskiy nshadskiy left review comments

Assignees

@SimonSPD SimonSPD

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonSPD @nshadskiy